feat(data-modeling): show collection name / relationship label in drawer header; show item associated actions in header COMPASS-9653 #7176
Conversation
…awer header; show item associated actions in header
gribnoysup
changed the title
gribnoysup
changed the title
gribnoysup
added
the
feature flagged
| // TODO(ticket): This is obviously a horrible selector and we should make sure | ||
| // that LG team provides a better one for us to achieve this behavior when | ||
| // we're removing the vendored version of the drawer | ||
| '& > div:nth-child(2) > div:nth-child(2) > div:first-child > div:first-child > div:first-child > div:first-child': |
There was a problem hiding this comment.
So a slightly less hacky version of this that I had initially was div:has(>strong), but our version of jsdom can't handle it and I didn't want to include version bump in this PR, but I'll revisit this after
| // layout the controls there better. Doing our best to target the section | ||
| // title here, leafygreen really doesn't give us anything else to try. | ||
| // | ||
| // TODO(ticket): This is obviously a horrible selector and we should make sure |
There was a problem hiding this comment.
Hoping to get a ticket number from this Slack thread
| const { id } = getActiveDrawerContent() || {}; | ||
| const lgIds = getLgIds(dataLgId); | ||
| const hasData = toolbarData && toolbarData.length > 0; | ||
| const { title, content } = | ||
| toolbarData.find((data) => { | ||
| return data.id === id; | ||
| }) ?? {}; |
There was a problem hiding this comment.
This is like a super minimal version of the fix that LG team did in this patch, mapping their changes on top of our vendored package was tricky due to naming (and seems like code was generally shifted around more there), but we can be sure that when this is not vendored anymore, this will continue working
There was a problem hiding this comment.
Actually, I promised a test for this, let me add that
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
Thank you! The title is actually a good idea, could we add it to the relationship items as well?
This patch changes the drawer title behavior in data-modeling to show a more specific label and also moves some drawer item related controls to the heading section. For now it's just one item that we show for relationships, but this will be expanded in the future, so I already tried to account for that